regis, 2 months ago

@stefanzweifel I’ve tried the level max on my projects and it’s just impossible.
I think even a default Laravel app doesn’t pass it.

mitelg, 2 months ago

@regis @stefanzweifel tip: use the baseline feature! this ensures that new added code has the desired level 🙂👍

stefanzweifel, 2 months ago

@regis yeah, max is basically impossible to fulfill in Laravel apps. In packages it’s manageable. A couple of doc blocks are usually enough.

thgs, 2 months ago

@stefanzweifel @regis what makes it hard to go max level in Laravel? I haven’t written any code related to laravel since version 5 but I wasn’t doing psalm/phpstan back then.

I usually try to go max and anything less is just “temporary” these days.

stefanzweifel, 2 months ago

@thgs @regis The problem is Laravel's magic.
Tools like Larastan or the laravel-ide-helper can help here.

The core problem is that for example in this User model, there are no $name or $email properties, but one can use $user->name = ‘Foo’;
https://github.com/laravel/laravel/blob/11.x/app/Models/User.php

As mentioned, I’m a novice when it comes to phpstan and currently don't see the need to go to level 9 in my projects.
My app code these days are often strictly typed PHP classes "outside" of Laravel anyway.

thgs, 2 months ago

@stefanzweifel @regis yea I see, I was just curious about what is the obstacle. Also way more competent with psalm than phpstan myself, magic properties are still possible but you would need to define a lot of psalm types. I think more or less the same for phpstan too.

It’s quite a bit of difference in the code in level 5 and then level 3 and then level 1 (reverse these for phpstan).

I tend to like the way you need to write the code in the max level because it ends up being guided a lot.