Hi! It's time for another #bevymergetrain :) Every week on Monday (pending illness and vacation), I go through #bevy's PR backlog to evaluate and hopefully merge any PR with two community approvals!
This week, there's 6 PRs ready: let's take a look!
Taffy upgrade! Wait, didn't I cover this last week? Oh, looks like the merge failed... Clicking through to the failed job, I'm getting errors that appear related. Let me ping the author.
I'll try updating the branch and merging just in case, but I suspect this is a case where we added a new segment that uses this code in a way that doesn't cause merge conflicts. Shouldn't be bad to fix up though.
More primitive shapes! This time, for arcs, circular sectors and circular segments. Really handy for targeting of attacks and vision cones: I'm pleased to see this fleshed out.
This is definitely at a "good enough state": we can fix up the remaining nits in follow-ups if needed. The author is a personal friend of mine: I'll check in and see how they're doing and adopt this if needed.
Pinging the author for merge conflict resolution, then merging :)
A nice simple PR to improve our fallbacks when generating reflected objects from scratch. The PR description is really clear: go read that!
This was approved a month and a half ago, and could have been merged then! pablo-lua, a new contributor who's done a great job pitching in with reviews, spotted this and added the label so it actually gets caught and merged. Thanks! Merging :)
Ah, this one is interesting. This fixes a long standing bug with a panic on window close on Linux, leading to messy logs and an ungraceful shutdown. Apparently the issue was actually with lifetimes to the raw resource being wrong, leading to a crash due to an early drop :(
Sensible enough fix, well-made and reviewed. Merging: it's nice to see that sort of thing actually find a resolution.
BD103 continues their spree of making Bevy's CI and infrastructure incrementally better to work with :D Love to see it: these PRs are so easy to review and merge, and just make the contributor experience subtly better.
This one is more internal documentation and a swap from pub(crate) to the simpler pub for our binary tools crate. Great, two thumbs up for me. They reverted a change away from mod.rs reviewers were eh on, making this an easy merge.
That's all for this week! I start full time with the Bevy Foundation on Wednesday: very keen to start bringing some of my cunning schemes to life.
In case you missed it, I'm also putting together a short poll for #rustlang#gamedev, in an attempt to gather feedback on the state of the language for making games in advance of meeting people at RustNL. Which is apparently next week?? So soon!
Add comment