arda, 7 months ago (edited 7 months ago)

So here's the Poll !

#poll

teodorsandu, 7 months ago

@arda oh, and my answer would have been Approach 3: ['key1', 'key2'].every(itm => typeof(obj[itm]) !== 'undefined');

After running the benchmark i saw i was very close actually, 2nd fastest, almost as fast as the 'in' operator https://measurethat.net/Benchmarks/Show/977/0/undefined-vs-typeof-vs-in-vs-hasownproperty

So the fastest way is Approach 4: ['key1', 'key2'].every(itm => itm in obj);

arda, 7 months ago

@teodorsandu Ahh, didn't think about the in operator while posting. Nice one, thanks! I'd choose 4 now I seen it.

Between 1 and 2, I believe for every iteration since Object.keys() is regenerated, approach 1 would work faster.

teodorsandu, 7 months ago

@arda hasOwnProperty is right there with typeof, 'in' and double negation, its complexity must be O(1) as well. So yes, it definitely wins over anything that spends time creating and iterating over arrays.

arda, 7 months ago

@teodorsandu You actually benched this? Thanks, that's awesome!

I also wonder how the results would change if the compared fields (['key1', 'key2'] part) is huge.

teodorsandu, 7 months ago

@arda not exactly, i just added an equivalent, simplified version to the existing test i linked earlier. There's a Fork button you can use to add you own test cases.

teodorsandu, 7 months ago

@arda hint: you could actually Add a Poll, via the button next to the Attachments button which you used to upload the image.

arda, 7 months ago

@teodorsandu If photo is uploaded I cannot add a poll, also I wanted descriptions such as your last toot hence I didn't add a poll. I'll add a new reply as a poll. Cheers.

teodorsandu, 7 months ago

@arda well, we learn new things every day :) i never noticed that one button gets hidden once you use the other until you pointed it out - thanks! and sorry for the unnecessary suggestion

arda, 7 months ago

@teodorsandu No problems at all! We all learn/discover new things every day indeed 🙌