There’s a mix of pride and suspicion whenever my PRs get accepted without requests for change. It’s “fuck yeah I’m the best engineer!!!1” on the one hand and “I’m sure my reviewer missed something… let me run the tests again” on the other.
@marta this is actually one of the reasons I try to always have some sort of suggested change. Something that might improve things, something that might teach them something... Anything
I very rarely make it "mandatory" though. That tends to defeat the whole purpose to me. There's such a wide range between optimal, and acceptable, and all the various permutations of those. Why would one of those prevent the others from being acceptable?
Add comment