danzin,
@danzin@mastodon.social avatar

There's this very useful and widely used tool, @coveragepy, that creates HTML coverage reports and uses in them.

I have proposed a simple PR to fix a small issue in sorting columns in the reports: https://github.com/nedbat/coveragepy/pull/1768/files

However, I'm very bad at .

The behavior is working as intended, but I can't shake the feeling that my JS code is awful in some way I can't see.

Could you take a quick look at the diff and point out anything that should be improved? TIA!

hugovk,
@hugovk@mastodon.social avatar

@danzin @coveragepy One tip: avoid var, use let or const instead:
https://stackoverflow.com/a/11444416/724176

rzeta0,
@rzeta0@mastodon.social avatar

@hugovk @danzin @coveragepy does this mean var will be deprecated?

danzin,
@danzin@mastodon.social avatar

@hugovk @coveragepy Thank you very much!

Changed var to let and that led me to finding a place I was var declaring a variable twice.

  • All
  • Subscribed
  • Moderated
  • Favorites
  • python
  • DreamBathrooms
  • magazineikmin
  • InstantRegret
  • GTA5RPClips
  • ethstaker
  • Youngstown
  • everett
  • slotface
  • osvaldo12
  • rosin
  • mdbf
  • kavyap
  • thenastyranch
  • ngwrru68w68
  • provamag3
  • Durango
  • modclub
  • cubers
  • khanakhh
  • Leos
  • tacticalgear
  • cisconetworking
  • vwfavf
  • tester
  • anitta
  • normalnudes
  • megavids
  • JUstTest
  • All magazines