From gratuitous use of superfluous language features (a cleanup handler, for a single fd, srsly?) to inappropriate use of standard POSIX APIs (using connect+write on a socket that only sends one message and then gets closed, really?) Older compilers don't even support a cleanup attribute, and this code is used as a model of portability??
@hyc "abominable" -> you somehow managed in 2024 to have a compiler that doesn't provide the cleanup attribute (you should really ask for your money back), and there's a connect+write instead of a sendmsg? Wow, with these kind of standards your code must always be a work of art! <checks Gitlab> Oh. Oh no. Oh dear. Never mind.
@hyc "RAII patterns supported by all compilers that matter and used by the kernel and other major Linux projects are garbage bloat, asckchyually" is exactly the kind of elitist drivel and delusion of grandeur that I was expecting, bravo, bullseye, 9/10
Anyway, the sample code is highly non-portable as given on their website. They need to either fix it or document which version of C compiler and which revision of C spec they require.
@hyc@wednesday well, any compiler used on any Linux from the last decade or more supports the cleanup stuff. And that pretty much matches systemd's intended audience.
Add comment