I migrated my self-hosted service backups from borg & self-made shell scripts to @borgmatic a short while back. After the first upgrade of borgmatic (1.8.6 -> 1.8.8, a minor version bump), automatic backups started failing because pre- and post command variables are apparently now interpreted as quoted shell arguments.
I'm contemplating if I should have stayed with plain borg.
@oranki The shell quoting change was a security fix to prevent shell injection attacks, and I'm sorry to hear it's broken stuff for you. If you'd like to file a ticket about it, I'd be happy to look at the specific issue you're encountering and see if there are any work-arounds: https://torsion.org/borgmatic/#issues
@borgmatic Thanks, I don't think a ticket is necessary, since its a deliberate change and no doubt a necessary one.
The problem for me was that I had a constant containing "/path/to/command --flag value", which was then used in commands like "{constant} --additional-flag value". Due to the change "/path/to/command --flag value" was interpreted as the actual name of the executable.
@oranki Yeah, I can see how that breaking would be obnoxious. Unfortunately I don't have any good suggestions except maybe using a separate constant for just "/path/to/command" without the flag. You can also just shell out to an actual shell script if you need more advanced scripting than borgmatic's hooks can provide.
Add comment